[M] Change in flashrom[master]: libflashrom.c: Invert if conditions to improve the readability - flashrom-gerrit

6 Dec 2022


      Attention is currently required from: Edward O'Callaghan.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68153 )
Change subject: libflashrom.c: Invert if conditions to improve the readability
......................................................................
Patch Set 6:
(1 comment)
File libflashrom.c:
https://review.coreboot.org/c/flashrom/+/68153/comment/17e2a7af_3968d9ab 
PS3, Line 107: (enum flashrom_test_state)
...
There are duplicate definitions for this. `test_state` in flash. […]
So yes, the cast is needed for now. I'm setting this to resolved since it's unrelated.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/68153
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I4021d8802cd041dcca29a226af0798ebd9c5a81b
Gerrit-Change-Number: 68153
Gerrit-PatchSet: 6
Gerrit-Owner: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 06 Dec 2022 23:03:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer felixsinger@posteo.net
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment