Attention is currently required from: Nico Huber, Thomas Heijligen, Aarya, Anastasia Klimchuk.
Simon Buhrow has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/66104 )
Change subject: flashrom.c: Add wrapper function to use the erase algorithm
......................................................................
Patch Set 67:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/66104/comment/5f012e68_3ad04ba9
PS67, Line 1151: flashctx->chip->read(flashctx, curcontents + region_start, region_start, old_start - region_start);
When I am running unit test CB:67535 it logs repeated invocations of reads with len==0 for all scena […]
What about checking if boundarys have been aligned? This would save the unnecessary read invocations and would make the code easier to understand as well (as l. 1148 to 1158 are only necessary in case of alignment).
--
To view, visit
https://review.coreboot.org/c/flashrom/+/66104
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I29e3f2bd796759794184b125741a5abaac6f3ce8
Gerrit-Change-Number: 66104
Gerrit-PatchSet: 67
Gerrit-Owner: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Simon Buhrow
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk
aklm@chromium.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 10 Nov 2022 09:37:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment