Attention is currently required from: Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51243 )
Change subject: Enable dynamic memory allocation checks for cmocka unit tests
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/51243/comment/af783c65_e95b2ea4
PS1, Line 7: .
nit: no trailing period in the commit summary
Done
File tests/flashrom.c:
https://review.coreboot.org/c/flashrom/+/51243/comment/4dd51d92_ae7c9b91
PS1, Line 31: free(text);
I'd define a helper macro to avoid repeating this pattern: […]
Thank you so much! This explanation is super useful for me.
And also I can see that I need to use do-while in macro in my other patch as well.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51243
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0c6b6b8dc17aaee28640e3fca3d1fc9f7feabf5f
Gerrit-Change-Number: 51243
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Daniel Kurtz
djkurtz@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Mon, 15 Mar 2021 23:32:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment