Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71622 )
Change subject: dmi.c: Pass is_laptop by ref into dmi
......................................................................
Patch Set 4:
(2 comments)
File internal.c:
https://review.coreboot.org/c/flashrom/+/71622/comment/b89fa31a_3f646478
PS4, Line 31: laptop_ok
Can we start this chain by moving this to `g_laptop_ok`. With it the FIXME below would also be fixed.
https://review.coreboot.org/c/flashrom/+/71622/comment/62361f7b_19e960be
PS4, Line 272:
?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/71622
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3d5ad6c0623269492d775a99a947fd6fe26c5f91
Gerrit-Change-Number: 71622
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 08 Mar 2023 22:35:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment