Attention is currently required from: Xiang Wang, Stefan Reinauer, Edward O'Callaghan.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49255 )
Change subject: bitbang-spi.c: support clock polarity and phase
......................................................................
Patch Set 14:
(2 comments)
File bitbang_spi.c:
https://review.coreboot.org/c/flashrom/+/49255/comment/bc7652ca_f21a1c43
PS14, Line 74: bitbang_spi_set_sck_set_mosi
Where did this go?
https://review.coreboot.org/c/flashrom/+/49255/comment/5bd932a7_6aca3ab4
PS14, Line 68: bitbang_spi_set_sck_set_mosi
If you're reordering the operations inside this function, I would also rename everything accordingly. Preferably, in a separate patch.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49255
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04c1dfe132d756119229b27c3cd611d1be1abc8d
Gerrit-Change-Number: 49255
Gerrit-PatchSet: 14
Gerrit-Owner: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Xiang Wang
merle@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Sun, 10 Jan 2021 11:16:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment