Anastasia Klimchuk has submitted this change. ( https://review.coreboot.org/c/flashrom/+/66903 )
Change subject: dmi.c: Retype variable `anchored` with bool ......................................................................
dmi.c: Retype variable `anchored` with bool
Use the bool type instead of an integer for the variable `anchored`, since this represents its purpose much better.
Signed-off-by: Felix Singer felixsinger@posteo.net Change-Id: I5bedaf47cdd2fd5d152f69b6b02aab69fd1285c6 Reviewed-on: https://review.coreboot.org/c/flashrom/+/66903 Reviewed-by: Anastasia Klimchuk aklm@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M dmi.c 1 file changed, 21 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Anastasia Klimchuk: Looks good to me, approved
diff --git a/dmi.c b/dmi.c index 7c0fc4c..beeb10f 100644 --- a/dmi.c +++ b/dmi.c @@ -27,6 +27,7 @@ #include <strings.h> #include <string.h> #include <ctype.h> +#include <stdbool.h> #include <stdio.h> #include <stdlib.h>
@@ -432,7 +433,7 @@ */ static int dmi_compare(const char *value, const char *pattern) { - int anchored = 0; + bool anchored = false; int patternlen;
msg_pspew("matching %s against %s\n", value, pattern); @@ -441,7 +442,7 @@ return 1;
if (pattern[0] == '^') { - anchored = 1; + anchored = true; pattern++; }
@@ -458,7 +459,7 @@
/* start character to make ends match */ value += valuelen - patternlen; - anchored = 1; + anchored = true; }
if (anchored)