Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54712 )
Change subject: sb600spi.c: Move sb600_spibar into spi data instead of being global
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
File sb600spi.c:
https://review.coreboot.org/c/flashrom/+/54712/comment/dcbee9ee_d0a9dbcb
PS1, Line 610: free(data);
I am not quite sure whether I need to free sb600_data->sb600_spibar here. […]
not free'ed as its physical memory but technically it should be unmapped yes although I think everyone leaks it across the tree and its there is about five'ish cases of spibar being a global.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ifaad0f0a2c0e956029d2df18ddcfd092515ca3c0
Gerrit-Change-Number: 54712
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 20 May 2021 02:21:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment