Attention is currently required from: Edward O'Callaghan.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72821 )
Change subject: programmer_table.c: Allow name_to_entry() to return default when set
......................................................................
Patch Set 1: -Code-Review
(1 comment)
File programmer_table.c:
https://review.coreboot.org/c/flashrom/+/72821/comment/5922fc8f_f5d7a262
PS1, Line 184: if (strlen(name) == 0) {
Same here, when passing a NULL pointer this function dies.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72821
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I75fd24a76d0f6f25072428a8d992a1977c4ad1f8
Gerrit-Change-Number: 72821
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Comment-Date: Tue, 14 Feb 2023 17:03:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment