Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64488 )
Change subject: dummyflasher: Wire variable size feature via opaque infra
......................................................................
Patch Set 3:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/64488/comment/ddc854ac_a9dba977
PS1, Line 1269: rmst.spi = *s_mst;
: rmst.opaque = *o_mst;
So... do you think it's too bad? :) I don't have another ideas at the moment :\ […]
Good news: I got rid of double master! Now everything is done as opaque master. I will leave another comment unresolved to verify with the users of the feature, but at the moment I am optimistic :)
I noticed something:
when I tried to port things from chromium myself
Wow I didn't know that you have experience porting things from chromium!
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64488
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I76402bfdf8b1a75489e4509fec92c9a777d0cf58
Gerrit-Change-Number: 64488
Gerrit-PatchSet: 3
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-CC: Namyoon Woo
namyoon@google.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 25 May 2022 00:47:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment