Change in flashrom[master]: dummyflasher: Add error check for file read

[Jacob Garber (Code Review)]

Jacob Garber has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34845 )

Change subject: dummyflasher: Add error check for file read
......................................................................

dummyflasher: Add error check for file read

Print an error message and return if the read from emu_persistent_image
fails.

Change-Id: Icd1a72f9171e547f2081ba4bc53834a17ef7fcab
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1403912
---
M dummyflasher.c
1 file changed, 6 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/flashrom refs/changes/45/34845/1

diff --git a/dummyflasher.c b/dummyflasher.c
index 0caffc9..2d7fa85 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -390,8 +390,12 @@
    	if (image_stat.st_size == emu_chip_size) {
    		msg_pdbg("matches.\n");
    		msg_pdbg("Reading %s\n", emu_persistent_image);
-			read_buf_from_file(flashchip_contents, emu_chip_size,
-					   emu_persistent_image);
+			if (read_buf_from_file(flashchip_contents, emu_chip_size,
+					   emu_persistent_image)) {
+				msg_perr("Unable to read %s\n", emu_persistent_image);
+				free(flashchip_contents);
+				return 1;
+			}
    	} else {
    		msg_pdbg("doesn't match.\n");
    	}

[David Hendricks (Code Review)]

David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34845 )

Change subject: dummyflasher: Add error check for file read
......................................................................

Patch Set 1: Code-Review+2

[Nico Huber (Code Review)]

Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/34845 )

Change subject: dummyflasher: Add error check for file read
......................................................................

dummyflasher: Add error check for file read

Print an error message and return if the read from emu_persistent_image
fails.

Change-Id: Icd1a72f9171e547f2081ba4bc53834a17ef7fcab
Signed-off-by: Jacob Garber 
Found-by: Coverity CID 1403912
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34845
Tested-by: build bot (Jenkins) 
Reviewed-by: David Hendricks 
---
M dummyflasher.c
1 file changed, 6 insertions(+), 2 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  David Hendricks: Looks good to me, approved

diff --git a/dummyflasher.c b/dummyflasher.c
index 0caffc9..2d7fa85 100644
--- a/dummyflasher.c
+++ b/dummyflasher.c
@@ -390,8 +390,12 @@
    	if (image_stat.st_size == emu_chip_size) {
    		msg_pdbg("matches.\n");
    		msg_pdbg("Reading %s\n", emu_persistent_image);
-			read_buf_from_file(flashchip_contents, emu_chip_size,
-					   emu_persistent_image);
+			if (read_buf_from_file(flashchip_contents, emu_chip_size,
+					   emu_persistent_image)) {
+				msg_perr("Unable to read %s\n", emu_persistent_image);
+				free(flashchip_contents);
+				return 1;
+			}
    	} else {
    		msg_pdbg("doesn't match.\n");
    	}