Attention is currently required from: Nico Huber, Angel Pons.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59073 )
Change subject: dummyflasher: emulate SR2 for W25Q128FV
......................................................................
Patch Set 17:
(2 comments)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/59073/comment/0b4cf592_6f3cd61f
PS16, Line 344: data->emu_status[1] |= (writearr[2] & ~ro_bits);
Spurious change?
Ack
https://review.coreboot.org/c/flashrom/+/59073/comment/73bb1ceb_c0993e60
PS16, Line 180: }
So, if we treat this as yet another property of the emulated chip, […]
We can't generalize this. Exact value of the mask changes depending on the values of separate bits, which are set dynamically, so custom code will always be needed.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I79f9b4a0b604663d3288ad70dcbe3ea4075dede5
Gerrit-Change-Number: 59073
Gerrit-PatchSet: 17
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sat, 18 Dec 2021 18:06:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment