Attention is currently required from: Nico Huber, Samir Ibradžić. Alan Green has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55695 )
Change subject: ft2232_spi: Revise comments about output pin states ......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Alan, Samir, I'm sorry about the reverts. I think it's best to […]
Hi Nico,
Thanks for your time and attention on this.
I think I understand what's going on here: the intent of the csgpiol parameter was to specify additional GPIOL pins that should mirror the CS pin. My changes were attempting to use the same machinery as csgpiol, but to control a general GPIO mechanism.
Is that right?
(For unfortunate reasons, this worked fine with the ad-hoc programmer we are using, and I didn't notice the change in behavior it caused for other programmers).
It's probably still useful to have a mechanism to set the GPIO pins, but it would be best for to start again, so I'm OK with the reverts.
btw, I'm going to be away for the next few weeks, so responses may be delayed.
Thanks,
Alan