Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56413 )
Change subject: tests: Mock file i/o for linux_mtd and linux_spi tests ......................................................................
Patch Set 8:
(2 comments)
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/56413/comment/b75d9c3f_b1433672 PS6, Line 236: strcpy(
size_t len = min(size*len, strlen(entry.data)); […]
Thank you! I used this code, only added strlen + 1 for \0
https://review.coreboot.org/c/flashrom/+/56413/comment/08f011ce_ede3ea62 PS6, Line 269: strlen(max_buf_size)
min(len, strlen(max_buf_size))
I did that, but now I am a bit confused: there is strncpy in one function and memcpy in the other ? should that be the same in both places?
-
Anastasia Klimchuk (Code Review)