Attention is currently required from: DZ, Nikolai Artemiev, Stefan Reinauer.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/81563?usp=email )
Change subject: flashchips: Add support for MXIC MX25L3239E ......................................................................
Patch Set 6:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/81563/comment/169a9945_cede384b : PS3, Line 9523: 1024B
I found it is "4K-bit secured OTP" in datasheet, so maybe twice less?
Daniel, I noticed on this patch (and few others that you currently have under review), you left unresolved comments, why? I see that you fixed what the comment was asking, but did not resolve comment as Done.
For the reviewers (me, in this case), resolving comment as Done indicates that you are happy with the latest version of your patch, and reviewers can have another look. If the comment is not resolved as Done, reviewers are not sure, maybe you are still working on the patch, or testing it, so it's not ready yet.
If this patch is ready (and same for the others), you need to click Done on each comment. And then you need to Reply to the patch, there is a button on the top. Then you click Send, and after that all reviewers get an email, and this is an indication that the patch is ready. Thank you!
-
Anastasia Klimchuk (Code Review)