David Hendricks has posted comments on this change. ( https://review.coreboot.org/23021 )
Change subject: layout: Add -i <region>[:<file>] support. ......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/23021/7/flashrom.c File flashrom.c:
https://review.coreboot.org/#/c/23021/7/flashrom.c@2647 PS7, Line 2647: * processed and merged into newcontents since -i files take priority.
This comment still makes no sense to me. I'd guess it was […]
Looking back, this seems to have been messed up in translation. My fault. The comment is also confusing given how the code is structured in the upstream codebase with Nico's libflashrom patches merged.
The `else` is incorrect and in do_verify(). We should always read_buf_from_include_args() if `-i region:filename` is used. We should read the full file if `filename` is specified for -w/-v, and then read the `-i region:file` args to update the content in the buffer.
For reference, refer to lines 2058-2091 and 2124-2134 in https://chromium.googlesource.com/chromiumos/third_party/flashrom/+/master/f...
-
David Hendricks (Code Review)