Change in flashrom[master]: [RFC][WPTST] tests: test write protection - flashrom-gerrit

2 Dec 2021


      Attention is currently required from: Nico Huber, Sergii Dmytruk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: [RFC][WPTST] tests: test write protection
......................................................................
Patch Set 11:
(2 comments)
File tests/chip_wp.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/632f48cd_cdda1c59 
PS11, Line 143: 0x00fff000
Where does this magic number come from?
https://review.coreboot.org/c/flashrom/+/59075/comment/37dcffab_bceff060 
PS11, Line 326: assert_int_equal(0x004000, range.start);
              : 	assert_int_equal(0xffc000, range.len);
Maybe I don't understand this properly, but aren't the values flipped?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/59075
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8
Gerrit-Change-Number: 59075
Gerrit-PatchSet: 11
Gerrit-Owner: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski maciej.pijanowski@3mdeb.com
Gerrit-CC: Nikolai Artemiev nartemiev@google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 02 Dec 2021 10:26:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment