HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/34404 )
Change subject: spi25: Remove dead increment ......................................................................
spi25: Remove dead increment
Value stored in 'pos' is never read.
Found-by scan-build: 7.0.1-8 Change-Id: I9a70593f182d7558e71e831fc2b834ac58a25b2a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M spi25.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/34404/1
diff --git a/spi25.c b/spi25.c index 36f265a..2a1d492 100644 --- a/spi25.c +++ b/spi25.c @@ -782,7 +782,6 @@ if (pos < start + len) { if (spi_chip_write_1(flash, buf + pos - start, pos, pos % 2)) return SPI_GENERIC_ERROR; - pos += pos % 2; }
return 0;
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34404 )
Change subject: spi25: Remove dead increment ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/34404/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/flashrom/+/34404/1//COMMIT_MSG@11 PS1, Line 11: Found-by missing colon
Hello build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/34404
to look at the new patch set (#2).
Change subject: spi25: Remove dead increment ......................................................................
spi25: Remove dead increment
Value stored in 'pos' is never read.
Found-by: scan-build 7.0.1-8 Change-Id: I9a70593f182d7558e71e831fc2b834ac58a25b2a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M spi25.c 1 file changed, 0 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/04/34404/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/34404 )
Change subject: spi25: Remove dead increment ......................................................................
Patch Set 2: Verified+1
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/flashrom/+/34404 )
Change subject: spi25: Remove dead increment ......................................................................
spi25: Remove dead increment
Value stored in 'pos' is never read.
Found-by: scan-build 7.0.1-8 Change-Id: I9a70593f182d7558e71e831fc2b834ac58a25b2a Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/flashrom/+/34404 Tested-by: Nico Huber nico.h@gmx.de Reviewed-by: Nico Huber nico.h@gmx.de --- M spi25.c 1 file changed, 0 insertions(+), 1 deletion(-)
Approvals: Nico Huber: Verified; Looks good to me, approved
diff --git a/spi25.c b/spi25.c index 36f265a..2a1d492 100644 --- a/spi25.c +++ b/spi25.c @@ -782,7 +782,6 @@ if (pos < start + len) { if (spi_chip_write_1(flash, buf + pos - start, pos, pos % 2)) return SPI_GENERIC_ERROR; - pos += pos % 2; }
return 0;
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)