Attention is currently required from: Nico Huber, Angel Pons.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51979 )
Change subject: test_build.sh: use -C option of ninja
......................................................................
Patch Set 2:
(1 comment)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/51979/comment/15906a39_9f4c7e0f
PS1, Line 4: #make CONFIG_EVERYTHING=yes WARNERROR=yes
Did you mean to comment this line out?
No, that was a mistake.
I've not all dependencies for the make build available and commend it out for testing the meson part
--
To view, visit
https://review.coreboot.org/c/flashrom/+/51979
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I04a0fdf9b5126b9f4006e8229c3926ceb1013456
Gerrit-Change-Number: 51979
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 31 Mar 2021 11:45:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment