Attention is currently required from: Alexander Goncharov, Anastasia Klimchuk, Angel Pons, Edward O'Callaghan, Nikolai Artemiev, Stefan Reinauer, Swift Geek (Sebastian Grzywna), Thomas Heijligen.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/75906?usp=email )
Change subject: doc: Add new Development guidelines
......................................................................
Patch Set 5: Code-Review+2
(4 comments)
File doc/dev_guide/development_guide.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/94f860b3_c9c4888c :
PS5, Line 161: approproately
typo: appropriately
https://review.coreboot.org/c/flashrom/+/75906/comment/deec150a_25262a4f :
PS5, Line 235: -s
If the commit is already signed-off, will this add another signoff (probably not intended), or will it avoid adding a new one?
https://review.coreboot.org/c/flashrom/+/75906/comment/faaaf5be_3d899126 :
PS5, Line 235: you
typo: your
File doc/dev_guide/development_guidelines.rst:
https://review.coreboot.org/c/flashrom/+/75906/comment/0254372f_7d87ff4e :
PS2, Line 7: Set up the git repository and dev environment
Renamed to development guide, I am happy to rename this doc! […]
Fine by me; as long as the document title isn't overly specific (renaming it fixed that) and the section headings make sense (my earlier suggestions worked toward that) then it shouldn't be difficult to navigate.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/75906?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7fe9ab2e27fead8e795138294219b11240f15928
Gerrit-Change-Number: 75906
Gerrit-PatchSet: 5
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Swift Geek (Sebastian Grzywna)
swiftgeek@gmail.com
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Mon, 10 Jul 2023 04:12:02 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org
Gerrit-MessageType: comment