Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48949 )
Change subject: flashchips.c: Add support for XMC new SPI flash types
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
https://review.coreboot.org/c/flashrom/+/48949/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/flashrom/+/48949/3//COMMIT_MSG@16
PS3, Line 16: TEST=test
Was a test actually performed? […]
I edited the commit message to fix it up for you. Thanks for contributing, it would be great to see more of your chips added as well.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/48949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I15c51b0f1ed789bcb2cabe33bc830f8d5d916969
Gerrit-Change-Number: 48949
Gerrit-PatchSet: 6
Gerrit-Owner: luke
sixuerain@qq.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Carl-Daniel Hailfinger
hailfinger@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Uwe Hermann
uwe@hermann-uwe.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 01 Jan 2021 03:07:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Edward O'Callaghan
quasisec@chromium.org
Gerrit-MessageType: comment