[S] Change in flashrom[master]: flashrom.c: Don't crash when programmer parameter string is NULL - flashrom-gerrit

14 Sep 2022


      Attention is currently required from: Jonathon Hall.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67619 )
Change subject: flashrom.c: Don't crash when programmer parameter string is NULL
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/67619/comment/3892469c_be8739a9 
PS1, Line 9: commit 3b8b93e
...
Thanks for the comments on CB:66659 shame not to have caught them in the week before 😞 […]
Hmmm, how do I explain it more clearly... Ah, just look at CB:67649 and its small size, together with CB:67094 they achieve the goal CB:66659 intended to do: no more `programmer_param` global variable. 😊
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/67619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie13bdcf63c23d912dc9b774ae279f1ae5883e287
Gerrit-Change-Number: 67619
Gerrit-PatchSet: 1
Gerrit-Owner: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Thomas Heijligen src@posteo.de
Gerrit-Attention: Jonathon Hall jonathon.hall@puri.sm
Gerrit-Comment-Date: Wed, 14 Sep 2022 13:09:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Jonathon Hall jonathon.hall@puri.sm
Gerrit-MessageType: comment