Attention is currently required from: Aarya, Peter Marheine.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84078?usp=email )
Change subject: tests: Check verify op completed in full if chip memory modified
......................................................................
Patch Set 2:
(2 comments)
File tests/erase_func_algo.c:
https://review.coreboot.org/c/flashrom/+/84078/comment/e8a9b973_fbce8b31?usp... :
PS1, Line 60: uint8_t
Since this is true/false, just use `bool`.
Done
https://review.coreboot.org/c/flashrom/+/84078/comment/2c96901a_682f053a?usp... :
PS1, Line 77: == 0x1
I'd rather use implicit boolean conversion throughout (`if (g_state.was_modified[start])`).
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84078?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I3c5d55a0deb20f23f4072caac8c0dce04cc98fd4
Gerrit-Change-Number: 84078
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Aarya
aarya.chaumal@gmail.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Aarya
aarya.chaumal@gmail.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Mon, 02 Sep 2024 12:21:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org