Attention is currently required from: Vadim Bendebury, Edward O'Callaghan, Angel Pons. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64405 )
Change subject: Add W25Q512NW-IM ID to flashrom ......................................................................
Patch Set 2:
(3 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64405/comment/35bb06cf_25729bcc PS1, Line 15: C
Hmmm, so this and CL:3171890 have the same Change-Id, although they're on different Gerrit instances […]
Opps, forgot to change those lines. Done now, hopefully reusing the change id on CB gerrit instance won't cause any problems.
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/64405/comment/ac2f3237_62e4c66d PS1, Line 17973: .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ,
The 4BA stuff looks suspicious... […]
Done
https://review.coreboot.org/c/flashrom/+/64405/comment/181fabe1_1e3368a0 PS1, Line 17965: { : .vendor = "Winbond", : .name = "W25Q512NW-IM", : .bustype = BUS_SPI, : .manufacture_id = WINBOND_NEX_ID, : .model_id = WINBOND_NEX_W25Q512NW_IM, : .total_size = 64 * 1024, : .page_size = 256, : .feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA | FEATURE_4BA_ENTER_WREN | FEATURE_4BA_READ | FEATURE_4BA_FAST_READ, : .tested = TEST_OK_PREW, : .probe = probe_spi_rdid, : .probe_timing = TIMING_ZERO, : .block_erasers = : { : { : .eraseblocks = { {4 * 1024, 16384} }, : .block_erase = spi_block_erase_21, : }, { : .eraseblocks = { {4 * 1024, 16384} }, : .block_erase = spi_block_erase_20, : }, { : .eraseblocks = { {32 * 1024, 2048} }, : .block_erase = spi_block_erase_52, : }, { : .eraseblocks = { {64 * 1024, 1024} }, : .block_erase = spi_block_erase_dc, : }, { : .eraseblocks = { {64 * 1024, 1024} }, : .block_erase = spi_block_erase_d8, : }, { : .eraseblocks = { {64 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_60, : }, { : .eraseblocks = { {64 * 1024 * 1024, 1} }, : .block_erase = spi_block_erase_c7, : } : }, : .unlock = spi_disable_blockprotect, : .write = spi_chip_write_256, : .read = spi_chip_read, : .voltage = {1650, 1950}, : },
Please indent with tabs
Done
-
Nikolai Artemiev (Code Review)