Change in flashrom[master]: writeprotect: add {get,set}_wp_mode() - flashrom-gerrit

28 Feb 2022


      Attention is currently required from: Nikolai Artemiev, Sergii Dmytruk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58483 )
Change subject: writeprotect: add {get,set}_wp_mode()
......................................................................
Patch Set 64: Code-Review+1
(1 comment)
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58483/comment/7cc5d34f_c3ba7f73 
PS58, Line 366: 	}
...
General thought: That the positive path comes first in such an if and ?: […]
s/int/enum flashrom_wp_mode
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58483
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7b68e940f0e1359281806c98e1da119b4caf8405
Gerrit-Change-Number: 58483
Gerrit-PatchSet: 64
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Mon, 28 Feb 2022 09:50:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Gerrit-MessageType: comment