Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/54429 )
Change subject: Fix up handling of IFD chipsets ......................................................................
Fix up handling of IFD chipsets
When `CHIPSET_400_SERIES_COMET_POINT` got added, the `chipset_names` table was not updated. Add the missing entry and reorder it to be next to `CHIPSET_300_SERIES_CANNON_POINT` for consistency.
Change-Id: I4f4b31ecf91c432a2e82a92e274cb91ac166e635 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/54429 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Edward O'Callaghan quasisec@chromium.org Reviewed-by: Sam McNally sammc@google.com --- M ich_descriptors.c M programmer.h 2 files changed, 3 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Edward O'Callaghan: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/ich_descriptors.c b/ich_descriptors.c index c5f9f82..a6ac881 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -106,7 +106,8 @@ "5 series Ibex Peak", "6 series Cougar Point", "7 series Panther Point", "8 series Lynx Point", "Baytrail", "8 series Lynx Point LP", "8 series Wellsburg", "9 series Wildcat Point", "9 series Wildcat Point LP", "100 series Sunrise Point", - "C620 series Lewisburg", "300 series Cannon Point", "Apollo Lake", "Gemini Lake", + "C620 series Lewisburg", "300 series Cannon Point", "400 series Comet Point", + "Apollo Lake", "Gemini Lake", }; if (cs < CHIPSET_ICH8 || cs - CHIPSET_ICH8 + 1 >= ARRAY_SIZE(chipset_names)) cs = 0; diff --git a/programmer.h b/programmer.h index d3a7ba3..1a2e758 100644 --- a/programmer.h +++ b/programmer.h @@ -670,8 +670,8 @@ CHIPSET_100_SERIES_SUNRISE_POINT, /* also 6th/7th gen Core i/o (LP) variants */ CHIPSET_C620_SERIES_LEWISBURG, CHIPSET_300_SERIES_CANNON_POINT, - CHIPSET_APOLLO_LAKE, CHIPSET_400_SERIES_COMET_POINT, + CHIPSET_APOLLO_LAKE, CHIPSET_GEMINI_LAKE, };