Nico Huber has uploaded a new change for review. ( https://review.coreboot.org/19044 )
Change subject: ich_descriptors: Fix more odd +1's ......................................................................
ich_descriptors: Fix more odd +1's
+1 on everything doesn't make software greater per se.
Change-Id: Ifa5455c999e90ff9121aed29f542d71ac9ca2b1c Signed-off-by: Nico Huber nico.huber@secunet.com --- M ich_descriptors.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/19044/1
diff --git a/ich_descriptors.c b/ich_descriptors.c index 4260a8c..26d1f27 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -618,9 +618,9 @@ msg_pdbg2("=== Softstraps ===\n");
if (sizeof(desc->north.STRPs) / 4 + 1 < desc->content.MSL) { - max_count = sizeof(desc->north.STRPs) / 4 + 1; + max_count = sizeof(desc->north.STRPs)/ 4; msg_pdbg2("MSL (%u) is greater than the current maximum of %u entries.\n", - desc->content.MSL, max_count + 1); + desc->content.MSL, max_count); msg_pdbg2("Only the first %u entries will be printed.\n", max_count); } else max_count = desc->content.MSL;