[XL] Change in flashrom[master]: move manpage to sphinx - flashrom-gerrit

28 Feb 2023


      Attention is currently required from: Thomas Heijligen.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72619 )
Change subject: move manpage to sphinx
......................................................................
Patch Set 11: Code-Review+1
(2 comments)
Patchset:
PS11: 
Great job :)
File meson.build:
https://review.coreboot.org/c/flashrom/+/72619/comment/deca7a37_729900e8 
PS11, Line 4:   meson_version : '>=0.57.0',
How about mentioning it in the commit message? Something like:
"Increase the minimum version of meson to at least 0.57.0 to be able to pass environment variables to the custom_target() command."
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/72619
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iee9f1164c5913e47385e6f7d51dc7775a58b5a67
Gerrit-Change-Number: 72619
Gerrit-PatchSet: 11
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Comment-Date: Tue, 28 Feb 2023 12:40:11 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment