Change in flashrom[master]: ni845x_spi: handle PROGRAMFILES(X86) env var properly - flashrom-gerrit

17 Aug 2021


      Attention is currently required from: Miklós Márton, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/56636 )
Change subject: ni845x_spi: handle PROGRAMFILES(X86) env var properly
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
...
Unfortunately no. […]
What I remember from the original review: we used the ${} notation to avoid trouble
the clash with the literal parentheses. IIRC, it worked back then? so I wonder what
changed :-/
Note, ${} is still expanded by `make`. It just looks like a shell expansion.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/56636
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I397619a5038567d649a417ce6b9d8ac9e1c8c67b
Gerrit-Change-Number: 56636
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Miklós Márton martonmiklosqdev@gmail.com
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 17 Aug 2021 10:37:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton martonmiklosqdev@gmail.com
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Gerrit-MessageType: comment