Nico Huber has submitted this change. ( https://review.coreboot.org/c/flashrom/+/60843 )
Change subject: gfxnvidia: remove unused rget_io_perms() ......................................................................
gfxnvidia: remove unused rget_io_perms()
The gfxnvidia programmer does not use x86 IO Ports. Remove the dependency to it.
Change-Id: I1f0341390ccb698bc435760f4ead7de54e429a6e Signed-off-by: Thomas Heijligen thomas.heijligen@secunet.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/60843 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Felix Singer felixsinger@posteo.net Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M Makefile M gfxnvidia.c 2 files changed, 0 insertions(+), 5 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Singer: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/Makefile b/Makefile index 595c9cf..7859362 100644 --- a/Makefile +++ b/Makefile @@ -126,7 +126,6 @@ DEPENDS_ON_X86_PORT_IO := \ CONFIG_ATAHPT \ CONFIG_ATAPROMISE \ - CONFIG_GFXNVIDIA \ CONFIG_INTERNAL \ CONFIG_NIC3COM \ CONFIG_NICINTEL \ diff --git a/gfxnvidia.c b/gfxnvidia.c index 30c94b9..535467e 100644 --- a/gfxnvidia.c +++ b/gfxnvidia.c @@ -19,7 +19,6 @@ #include "flash.h" #include "programmer.h" #include "hwaccess.h" -#include "hwaccess_x86_io.h" #include "hwaccess_physmap.h" #include "platform/pci.h"
@@ -89,9 +88,6 @@ struct pci_dev *dev = NULL; uint32_t reg32;
- if (rget_io_perms()) - return 1; - dev = pcidev_init(gfx_nvidia, PCI_BASE_ADDRESS_0); if (!dev) return 1;