Alan Green has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/35091 )
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
flashchips.c: Identify MX25L25645G part
Apply downstream patch d978051c2e7da88088ec4ef19827c04873a5479d, "flashrom: Identify MX25L25645G part" from chris_zhou@compal.corp-partner.google.com 2019-04-13. Change description was:
MX25L25635F and MX25L25645G have the same chips identify. Add MX25L25645G to the name of the part so that it doesn't confused people.
Signed-off-by: Alan Green avg@google.com Change-Id: I317345b4753cfc46fdca8f673a0591e33b62138b --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35091/1
diff --git a/flashchips.c b/flashchips.c index 1c67887..f84f1cc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8109,7 +8109,7 @@
{ .vendor = "Macronix", - .name = "MX25L25635F", + .name = "MX25L25635F/MX25L25645G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25L25635F,
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/35091
to look at the new patch set (#2).
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
flashchips.c: Identify MX25L25645G part
Apply downstream patch d978051c2e7da88088ec4ef19827c04873a5479d, "flashrom: Identify MX25L25645G part" from chris_zhou@compal.corp-partner.google.com 2019-04-13. Change description was:
""" MX25L25635F and MX25L25645G have the same chips identify. Add MX25L25645G to the name of the part so that it doesn't confused people. """
Signed-off-by: Alan Green avg@google.com Change-Id: I317345b4753cfc46fdca8f673a0591e33b62138b --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/91/35091/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35091 )
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
Patch Set 2: Code-Review+2
The commit summary is a tad bit confusing, but the change is trivial enough
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35091 )
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/35091 )
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
Patch Set 2:
Jenkins won't verify this, should I trigger a rebase?
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/35091 )
Change subject: flashchips.c: Identify MX25L25645G part ......................................................................
flashchips.c: Identify MX25L25645G part
Apply downstream patch d978051c2e7da88088ec4ef19827c04873a5479d, "flashrom: Identify MX25L25645G part" from chris_zhou@compal.corp-partner.google.com 2019-04-13. Change description was:
""" MX25L25635F and MX25L25645G have the same chips identify. Add MX25L25645G to the name of the part so that it doesn't confused people. """
Signed-off-by: Alan Green avg@google.com Change-Id: I317345b4753cfc46fdca8f673a0591e33b62138b Reviewed-on: https://review.coreboot.org/c/flashrom/+/35091 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Edward O'Callaghan quasisec@chromium.org --- M flashchips.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Edward O'Callaghan: Looks good to me, approved
diff --git a/flashchips.c b/flashchips.c index 1c67887..f84f1cc 100644 --- a/flashchips.c +++ b/flashchips.c @@ -8109,7 +8109,7 @@
{ .vendor = "Macronix", - .name = "MX25L25635F", + .name = "MX25L25635F/MX25L25645G", .bustype = BUS_SPI, .manufacture_id = MACRONIX_ID, .model_id = MACRONIX_MX25L25635F,
-
Alan Green (Code Review) -
Angel Pons (Code Review)
-
Edward O'Callaghan (Code Review)