Attention is currently required from: Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64425 )
Change subject: flashchips.c: Fix 4BA for S25FL512S
......................................................................
Patch Set 1:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/64425/comment/43d56b98_ec289396
PS1, Line 9: any features
_NATIVE is already a set of features, namely 4BA read (0x13), fast read (0x0c) […]
Re-read the sentence and this might be what's causing confusion: The "native"
commands don't need a mode. They are supposed to work in any state and always
take 4-byte addresses.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64425
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I08c5a70351d945130183fe01c328dc4d30cfe0ef
Gerrit-Change-Number: 64425
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Wed, 18 May 2022 12:58:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment