Attention is currently required from: Antonio Vázquez Blanco.
Anastasia Klimchuk has posted comments on this change by Antonio Vázquez Blanco. ( https://review.coreboot.org/c/flashrom/+/84985?usp=email )
Change subject: Extract cli_output declarations to a separate header. ......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2: The same comment as on the CB:84983 , but also, one more thing.
I see that cli_output.c is not the latest. If you could rebase the patch on the latest head?
Also, given that the latest changes to cli_output.c were related to progress indicator, if you could run few tests after rebasing, for example:
flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -r dump.rom --progress flashrom -p dummy:emulate=W25Q128FV,freq=64mhz -E --progress