Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
ChrisEric1 CECL has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72057 )
Change subject: Add support for VIA VL805 USB Controller flashing ......................................................................
Patch Set 21:
(15 comments)
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/685ebe4b_bac9b1b3 PS18, Line 70: unsigned int i, j;
delete
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/5bcf1ffe_472bb996 PS18, Line 71: uint32_t outdata; : uint32_t indata; : unsigned int curwritecnt; : unsigned int curreadcnt;
scope to respective loop constructs..
Assuming you rewrote what you meant later.
File vl805.c:
https://review.coreboot.org/c/flashrom/+/72057/comment/2acaf72c_5e1c7784 PS20, Line 24: #include "programmer.h" : #include "spi.h" : #include "flash.h" : #include "platform/pci.h" : #include <stdlib.h>
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/d0ecb84c_71a9f3c4 PS20, Line 70: uint32_t outdata; : uint32_t indata;
delete
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/e8dc4ce5_3542903c PS20, Line 75: for (j = 0; j < writecnt; j += 4) {
`for (unsigned int i = 0; i < writecnt; i += 4) {`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/6d7455e0_805fabcf PS20, Line 76: j
i
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/eaaf8640_64fda1e6 PS20, Line 76: u
const
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/01c3b724_afeb1f6e PS20, Line 77: o
you can just do: […]
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/23533c2b_40d2f9d8 PS20, Line 78: for (i = 0; i < curwritecnt; i++) {
`for (unsigned int j = 0; j < curwritecnt; j++) {`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/0bc41809_8c5f4b53 PS20, Line 89: for (j = 0; j < readcnt; j += 4) {
`for (unsigned int i = 0; i < readcnt; i += 4) {`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/0b66f310_80affdc6 PS20, Line 90: j
i
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/04954815_54a7504b PS20, Line 90: u
const
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/9ef6592f_e7eab7cf PS20, Line 92: indata
`uint32_t data =`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/39c3b489_b57b0e3a PS20, Line 93: for (i = 0; i < curreadcnt; i++) {
`for (unsigned int j = 0; j < curreadcnt; j++) {`
Done
https://review.coreboot.org/c/flashrom/+/72057/comment/ce7f2125_668bc2f5 PS20, Line 94: i
j
Done
-
ChrisEric1 CECL (Code Review)