Attention is currently required from: Aarya, Alexander Goncharov, Anastasia Klimchuk, Nikolai Artemiev.
Peter Marheine has posted comments on this change by Peter Marheine. ( https://review.coreboot.org/c/flashrom/+/82393?usp=email )
Change subject: erasure_layout: Fix get_flash_region bug ......................................................................
Patch Set 16: Code-Review+2
(2 comments)
Patchset:
PS15:
So given that I added a piece of code, maybe you can review it :)
That looks fine to me! I also verified that the tests still fail if the code fix is reverted, which they do.
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/82393/comment/50d2e09e_99aa2048?usp... : PS13, Line 368: for (unsigned int addr = region_start; addr <= region_end; addr += len) {
I think this specific issue is outside of scope of the patch: mainly because it is not relevant to p […]
Yeah, that can be addressed separately. This change fixes an actual bug where we destroy data we don't intend to, whereas the other issue is just that some operations will take longer than they need to.
-
Peter Marheine (Code Review)