Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
Miklós Márton has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72160 )
Change subject: ni845x_spi: refactor singleton states into reentrant pattern
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Miklos, could you please help to review and test this chain of patches? […]
I tried test it (managed to put togeter a Windows image with the proper mingw, etc.) however the make fails due to the lack of sphinx-build (even make flashrom too.). If possible I would avoid going down the rabbit hole to get sphinx-build on the platform. I saw others complaining about it on the mailing list: is the sphinx-build dependency intentional?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/72160
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I45fcb8e20582cb0c532c4a9f0c78543a25f8d484
Gerrit-Change-Number: 72160
Gerrit-PatchSet: 3
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Fri, 14 Apr 2023 20:50:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment