Change in flashrom[master]: Add support to get layout from fmap (e.g. coreboot rom) - flashrom-gerrit

28 Jul 2018


      David Hendricks has posted comments on this change. ( https://review.coreboot.org/23203 )
Change subject: Add support to get layout from fmap (e.g. coreboot rom)
......................................................................
Patch Set 19:
(1 comment)
https://review.coreboot.org/#/c/23203/18/libflashrom.c
File libflashrom.c:
https://review.coreboot.org/#/c/23203/18/libflashrom.c@466
PS18, Line 466: rom_offset + len - sizeof
...
should it not be len + romoffset - sizeof(struct fmap) ?
d'oh! you're right. Fixed.
-- 
To view, visit https://review.coreboot.org/23203
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I0e7fad38ed79a84d41358e1f175c36d255786c12
Gerrit-Change-Number: 23203
Gerrit-PatchSet: 19
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: David Hendricks david.hendricks@gmail.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Werner Zeh werner.zeh@siemens.com
Gerrit-Comment-Date: Sat, 28 Jul 2018 07:28:00 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No