Attention is currently required from: Nikolai Artemiev.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68127 )
Change subject: s25f.c: Fix undefined behaviour on shift ......................................................................
Patch Set 1:
(4 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/68127/comment/c84e697d_220d5b03 PS1, Line 7: UB
There's enough space to use the full form: `undefined behavior` (or `undefined behaviour`, pick your […]
Done
https://review.coreboot.org/c/flashrom/+/68127/comment/82c2040b_1a60fb76 PS1, Line 7: p
spurious `p`
Done
https://review.coreboot.org/c/flashrom/+/68127/comment/9ee5e63d_58df48dc PS1, Line 9: 24
We had a teacher that would say "24 what? Potatoes?". Maybe reword this sentence as follows: […]
Done
Patchset:
PS1: thanks Angel
-
Evan Benn (Code Review)