Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/68279 )
Change subject: layout.c: Use calloc() to ensure a zeroed layout ......................................................................
layout.c: Use calloc() to ensure a zeroed layout
No need to malloc() and then do a DIY memset to zero of the heap. Just use calloc(1, ..) to get a zeroed heap.
Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M layout.c 1 file changed, 14 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/79/68279/1
diff --git a/layout.c b/layout.c index 0212699..be88428 100644 --- a/layout.c +++ b/layout.c @@ -355,14 +355,12 @@
int flashrom_layout_new(struct flashrom_layout **const layout) { - *layout = malloc(sizeof(**layout)); + *layout = calloc(1, sizeof(**layout)); if (!*layout) { msg_gerr("Error creating layout: %s\n", strerror(errno)); return 1; }
- const struct flashrom_layout tmp = { 0 }; - **layout = tmp; return 0; }