Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/25150 )
Change subject: linux_spi: Reduce maximum read chunksize ......................................................................
linux_spi: Reduce maximum read chunksize
It turned out that older kernels use a single buffer for combined input and output data. So we have to account for the read command + max 3 address bytes.
Change-Id: Ide50db38af1004fde09a70b15938e77f5e1285ac Signed-off-by: Nico Huber nico.huber@secunet.com Reviewed-on: https://review.coreboot.org/25150 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: David Hendricks david.hendricks@gmail.com --- M linux_spi.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved
diff --git a/linux_spi.c b/linux_spi.c index e51fbc4..d276402 100644 --- a/linux_spi.c +++ b/linux_spi.c @@ -183,7 +183,7 @@ unsigned int start, unsigned int len) { return spi_read_chunked(flash, buf, start, len, - (unsigned int)getpagesize()); + (unsigned int)getpagesize() - 4); }
static int linux_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len)