Attention is currently required from: Sergii Dmytruk.
Anastasia Klimchuk has posted comments on this change by Anastasia Klimchuk. ( https://review.coreboot.org/c/flashrom/+/84439?usp=email )
Change subject: Display progress for what is actually erased/written ......................................................................
Patch Set 9:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/84439/comment/79da4579_69079e41?usp... : PS7, Line 1265: // TODO: take FEATURE_NO_ERASE into account?
I found something to fix for FEATURE_NO_ERASE, although not here. […]
How it looks to me now, there can be two possible workarounds for FEATURE_NO_ERASE:
Either hacking spi_write_chunked so that it knows when it's erase instead of write
or re-init progress in between erase and write, then it would looks like WRITE 0...100 and then once more WRITE 0...100
It seem to me the latter it more realistic.
-
Anastasia Klimchuk (Code Review)