Attention is currently required from: Edward O'Callaghan, Hsuan-ting Chen, Sam McNally, Thomas Heijligen.
Anastasia Klimchuk has posted comments on this change by Edward O'Callaghan. ( https://review.coreboot.org/c/flashrom/+/73286?usp=email )
Change subject: libflashrom: Provide flashrom_flash_getinfo() API ......................................................................
Patch Set 9:
(2 comments)
Patchset:
PS3:
Good idea, done!
But the suggestion was `struct flashrom_flashchip_info *flashrom_get_active_flashchip(struct flashrom_flashctx*)`
which is not what the latest patch set has - different name (which I like more) and also info is returned
this is closed with "done", but what's done is not what the comments asked for?
Patchset:
PS9: Hello Hsuan Ting! I have a question - why this is needed and what is exactly the use case you have in mind, such that this new API is needed?
I can see there are other patches in the chain, but you haven't touched them and haven't rebased them, so I don't know if you were planning those?
I looked at the those other patches, and there is no explanation of why this API is needed. I can see few lines in cli classic are replaced with other few lines, but by itself it's not really the reason. The last patch in the chain says vaguely "Some users wish to work with numerical values over strings", but what exactly does it mean? How those users are using libflashrom?
If you could provide more concrete details that would be great, thank you!
-
Anastasia Klimchuk (Code Review)