Attention is currently required from: Thomas Heijligen, Stefan Reinauer, Anastasia Klimchuk.
Peter Marheine has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions ......................................................................
Patch Set 3:
(1 comment)
File doc/developers_doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/218e1cf7_861729a0 PS3, Line 175: .. todo:: Write a sphinx extension to render ``meson_options.txt`` here `meson configure` will print out all options including project-specific ones, and the inline documentation for options isn't very useful right now (it doesn't seem useful unless you already have some idea of what the options do).
I think the important options should either be documented manually here (providing more context for those that are typically interesting), or document that `meson configure` will show them (assuming that the plain information you get from there isn't very useful and it's not worth much effort to provide it inline here).
-
Peter Marheine (Code Review)