Attention is currently required from: Paul Menzel, Angel Pons. Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54943 )
Change subject: Add AmigaOS suppport to flashrom ......................................................................
Patch Set 1:
(4 comments)
File Makefile:
https://review.coreboot.org/c/flashrom/+/54943/comment/56cbe169_dd346e01 PS1, Line 141: Bus Pirate, Serprog and PonyProg are not supported under AmigaOS (missing serial support).
I'd rather not list all the programmers in the comment. Instead, I'd say something like this: […]
This code is copied verbatim from the MSDOS section. If it was good enough for MSDOS, it's good enough for Amiga OS ;)
https://review.coreboot.org/c/flashrom/+/54943/comment/e8c465b2_d348b0c0 PS1, Line 157: # Digilent SPI, Dediprog, Developerbox, USB-Blaster, PICkit2, CH341A and FT2232 are not supported under AmigaOS (missing USB support).
Same story here: […]
ditto
https://review.coreboot.org/c/flashrom/+/54943/comment/f0663414_6b880498 PS1, Line 213: DOS
AmigaOS
Caught me! I wish there was a better way of reusing this chunk for both MSDOS and AmigaOS
File flash.h:
https://review.coreboot.org/c/flashrom/+/54943/comment/c1e457f7_989a0623 PS1, Line 56: __AMIGA__
Why not use `IS_AMIGA` here?
I don't know. What are the rules for using IS_XXX vs the platform dependent defines? It seems (looking at the code below) that this is used inconsistently / interchangeably in the code base?
-
Stefan Reinauer (Code Review)