[S] Change in flashrom[master]: jedec.c: Use JEDEC_ define from spi.h over magic - flashrom-gerrit

31 Jan 2023


      Attention is currently required from: Edward O'Callaghan.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/72632 )
Change subject: jedec.c: Use JEDEC_ define from spi.h over magic
......................................................................
Patch Set 1:
(1 comment)
File jedec.c:
https://review.coreboot.org/c/flashrom/+/72632/comment/1a40f12f_7e7f64d4 
PS1, Line 135: JEDEC_REMS
Are we sure that this is more readable than the "magic" (given that two out of the three values remain "magic")
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/72632
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id0c98ee900e37c26dc06f96a9950713f332240fd
Gerrit-Change-Number: 72632
Gerrit-PatchSet: 1
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Tue, 31 Jan 2023 22:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment