Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Nikolai Artemiev.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add support for reading/writing WP configs
......................................................................
Patch Set 11:
(3 comments)
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/0265288a_338ea0d3
PS11, Line 4: 2010
It is 2021 now, you are adding the lines in 2021
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/535f2d19_eb5cdbf6
PS9, Line 128: return ret;
Done
But it is still the same, you haven't changed the code?
For every if (....)
body should be on the next line.
https://review.coreboot.org/c/flashrom/+/58479/comment/152b5623_840f01ef
PS9, Line 161: ord = cfga->cmp - cfgb->cmp;
Done
You forgot :)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58479
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I3ad25708c3321b8fb0216c3eaf6ffc07616537ad
Gerrit-Change-Number: 58479
Gerrit-PatchSet: 11
Gerrit-Owner: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 22 Nov 2021 01:50:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nikolai Artemiev
nartemiev@google.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment