Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57326 )
Change subject: tests: Add tests to read from chip ......................................................................
Patch Set 2:
(3 comments)
Patchset:
PS1:
Can the refactor and the new tests be split into two patches to make it slightly easier to review?
Yes, I created a chain so that it's more readable. Previous one CB:57436 extracts setup and teardown, this one adds new tests.
File tests/chip.c:
https://review.coreboot.org/c/flashrom/+/57326/comment/de3f172d_d46ef6d0 PS1, Line 232: 16
I was really wondering what this is about... I guess you mean the […]
There was something in my head when I was writing this comment, but I feel it's not that relevant anymore. I removed the comment (comes into effect in CB:57437). Also this size is really small, should be more realistic, which is also done in CB:57437. I recall now, in the very first chip test there was a comment on why chip is so small.
In general, I was thinking, this can be expanded to test small or large chips, and various eraseblocks.
https://review.coreboot.org/c/flashrom/+/57326/comment/7e55bdec_da035d2e PS1, Line 246: };
Should these be static/global so they can be shared among test functions?
Yes right, they started to repeat once more tests have been added. I created CB:57437 for this.
-
Anastasia Klimchuk (Code Review)