Edward O'Callaghan has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48744 )
Change subject: chipdrivers.h: Trivial fix style of write_28sf040() signature ......................................................................
chipdrivers.h: Trivial fix style of write_28sf040() signature
This is correct on the Chromium side so fix the missing space here.
Change-Id: I9dd27a4d8a1b87ce96b2a3f8cbe80f40c79b0354 Signed-off-by: Edward O'Callaghan quasisec@google.com --- M chipdrivers.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/44/48744/1
diff --git a/chipdrivers.h b/chipdrivers.h index b42c363..e1d6aa9 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -159,7 +159,7 @@ /* sst28sf040.c */ int erase_chip_28sf040(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int erase_sector_28sf040(struct flashctx *flash, unsigned int address, unsigned int sector_size); -int write_28sf040(struct flashctx *flash, const uint8_t *buf,unsigned int start, unsigned int len); +int write_28sf040(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int unprotect_28sf040(struct flashctx *flash); int protect_28sf040(struct flashctx *flash);
Sam McNally has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48744 )
Change subject: chipdrivers.h: Trivial fix style of write_28sf040() signature ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48744 )
Change subject: chipdrivers.h: Trivial fix style of write_28sf040() signature ......................................................................
Patch Set 1: Code-Review+2
Edward O'Callaghan has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48744 )
Change subject: chipdrivers.h: Trivial fix style of write_28sf040() signature ......................................................................
chipdrivers.h: Trivial fix style of write_28sf040() signature
This is correct on the Chromium side so fix the missing space here.
Change-Id: I9dd27a4d8a1b87ce96b2a3f8cbe80f40c79b0354 Signed-off-by: Edward O'Callaghan quasisec@google.com Reviewed-on: https://review.coreboot.org/c/flashrom/+/48744 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Sam McNally sammc@google.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M chipdrivers.h 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved Sam McNally: Looks good to me, approved
diff --git a/chipdrivers.h b/chipdrivers.h index b42c363..e1d6aa9 100644 --- a/chipdrivers.h +++ b/chipdrivers.h @@ -159,7 +159,7 @@ /* sst28sf040.c */ int erase_chip_28sf040(struct flashctx *flash, unsigned int addr, unsigned int blocklen); int erase_sector_28sf040(struct flashctx *flash, unsigned int address, unsigned int sector_size); -int write_28sf040(struct flashctx *flash, const uint8_t *buf,unsigned int start, unsigned int len); +int write_28sf040(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len); int unprotect_28sf040(struct flashctx *flash); int protect_28sf040(struct flashctx *flash);