[S] Change in flashrom[master]: flashrom.c:Add a function to get list of sectors that need erasing
Attention is currently required from: Simon Buhrow, Edward O'Callaghan.
Aarya has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/65844 )
Change subject: flashrom.c:Add a function to get list of sectors that need erasing ......................................................................
Patch Set 74:
(6 comments)
File erasure_layout.c:
https://review.coreboot.org/c/flashrom/+/65844/comment/151a1291_97ff5db6 PS73, Line 127: region_end
`rend` and Doxygen.
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/0816ab4d_167f38e7 PS73, Line 127: void *
`void *` in type system speak is mostly like putting on a blind-fold and jumping between a large can […]
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/fdee2ac5_28cd8b26 PS73, Line 127: region_start
`rstart` and Doxygen.
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/fd0be5ef_5bc380ff PS73, Line 127: function_index
`findex` and in the Doxygen comment you can say "function index".
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/a432e29b_bd28e321 PS73, Line 127: struct flashctx *flashctx,
by convention, keep the `flashctx` as the first argument to the function, it helps keep the code-bas […]
Done
https://review.coreboot.org/c/flashrom/+/65844/comment/75d3e6c3_55578ac9 PS73, Line 130: function_index == 0
`!foo` is canonical for the 0 or NULL case.
Done
-
Aarya (Code Review)