Attention is currently required from: Thomas Heijligen, Anastasia Klimchuk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55999 )
Change subject: layout: Turn overlap debug message into warning
......................................................................
Patch Set 1:
(1 comment)
File layout.c:
https://review.coreboot.org/c/flashrom/+/55999/comment/5d6f893b_23ec4ed8
PS1, Line 269: warn
It's certainly unexpected. The only place where this is currently called from treats this as an error.
That's it. And the only case when the warnings would be spurious would be
when the caller wanted to handle the overlapping somehow explicitly. But
then it would have to walk the layout again to find the details. Which
makes this function less useful for such a case, I guess.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/55999
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ie969e0538d302ccd58d3fec3921265ed3621eaa5
Gerrit-Change-Number: 55999
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Fri, 02 Jul 2021 12:11:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment