Change in flashrom[master]: dummyflasher.c: Don't leak `emu_persistent_image` - flashrom-gerrit

26 May 2021


      Attention is currently required from: Nico Huber, Angel Pons, Arthur Heymans.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54905 )
Change subject: dummyflasher.c: Don't leak `emu_persistent_image`
......................................................................
Patch Set 1:
(1 comment)
File dummyflasher.c:
https://review.coreboot.org/c/flashrom/+/54905/comment/6113fea7_bcb0ad82 
PS1, Line 1026: free(data->emu_persistent_image);
...
...
Is it ok to free something which is !(not) ? […]
Oh thank you, super useful!
So the code like `if (pointer) free(pointer)` is not needed, just `free(pointer)` is sufficient? Specifically, when I write new code?
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/54905
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I76529973cefcc6a1472681e1f4da8239fcbf07a6
Gerrit-Change-Number: 54905
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 26 May 2021 22:04:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Comment-In-Reply-To: Angel Pons th3fanbus@gmail.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment